[release/1.7] snapshots: emit deprecation warning for aufs #9436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9312
aufs snapshotter is already removed from main, so this PR is directly against 1.7. However, the approach here is a bit weird, and I'm open to feedback on doing it differently if that's warranted. Here's the weirdness:
So instead of that, I added the warning service as a dependency of the snapshot service, and emit the warning from there. It's certainly less elegant, but it was many fewer steps.