Update cri-api to v0.29.1

[kiashok]

Update k8s.io/cri-api to v0.29.1

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[kiashok]

/test all

[kiashok]

Hi @dmcgowan @mikebrow , the v1.29 alpha3 tag of upstream k8s requires 1.21.3 golang version. But it looks like we don't allow 1.21.x version in containerd golang? Is there a way I could work around this?
I would like to update to the newer patch of k8s cri-api to send out PRs for the image pull per runtime class changes.

[estesp]

We default to 1.21.3 in our CI GH Actions script, but we verify that containerd still builds with Go 1.20.x as that release is still supported (see here).

I guess if upstream Kubernetes 1.29 is going to require Go 1.21 we will have to discuss how to handle that requirement in our project.

[k8s-ci-robot]

@kiashok: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test pull-containerd-build
• /test pull-containerd-node-e2e

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kiashok]

/test all

[kiashok]

We default to 1.21.3 in our CI GH Actions script, but we verify that containerd still builds with Go 1.20.x as that release is still supported (see here).

I guess if upstream Kubernetes 1.29 is going to require Go 1.21 we will have to discuss how to handle that requirement in our project.

kubernetes/cri-api@5a34c2b this commit was made to fix this kubernetes/kubernetes#121338 . Started a thread for this discussion on sig-release. Not sure if its a hard requirement for cri-api v1.29 to stay on golang 1.21

cc @dims @dmcgowan @thaJeztah

[dims]

@kiashok i don't think the error means that... it just objects that the format is A.B.C and not just A.B.

If you see latest https://github.com/kubernetes/cri-api/blob/master/go.mod#L5 we fixed it already, if you wait for rc2 you should be all set i think. you can check this theory by editing the file in your PR by hand

[thaJeztah]

@kiashok i don't think the error means that... it just objects that the format is A.B.C and not just A.B.

If you see latest https://github.com/kubernetes/cri-api/blob/master/go.mod#L5 we fixed it already, if you wait for rc2 you should be all set i think. you can check this theory by editing the file in your PR by hand

Currently, the error is about the SemVer format (which is not supported by go1.20), but unfortunately, the version in go mod is now a required version as well, no longer an "indicative" / "recommended" version;

Here's a quick example using a "mymodule" module, which uses go 1.22 in its go.mod;

tree
.
├── go.mod
├── main.go
└── mymodule
    ├── foo.go
    └── go.mod


cat mymodule/go.mod
module example.com/mymodule

go 1.22

Trying to use such a module in a project; means it cannot be used on go1.20 or go1.21.

at go.mod
module myproject


require "example.com/mymodule" v0.0.0

replace "example.com/mymodule" => ./mymodule

This worked until go1.20.7 and go1.19.12;

docker run --rm -v $(pwd):/myproject -w /myproject golang:1.20.7 sh -c 'go run main.go'
hello:hello

docker run --rm -v $(pwd):/myproject -w /myproject golang:1.19.12 sh -c 'go run main.go'
hello:hello

But no longer works in go1.20.8 and go1.19.13;

docker run --rm -v $(pwd):/myproject -w /myproject golang:1.20.8 sh -c 'go run main.go'
example.com/mymodule: cannot compile Go 1.22 code

docker run --rm -v $(pwd):/myproject -w /myproject golang:1.19.13 sh -c 'go run main.go'
example.com/mymodule: cannot compile Go 1.22 code

Same for go1.21, but with a slightly different error-message;

go run main.go
go: example.com/mymodule@v0.0.0: module ./mymodule requires go >= 1.22 (running go 1.21.4)

[kiashok]

@thaJeztah @dmcgowan @estesp @dcantah all the tests are passing. Could you please take a look when you have some time please?

[kiashok]

@fuweid @estesp @dmcgowan @dcantah could you please take a look when you have some time please? :)

[fuweid]

.github/workflows/release.yml

The go version in release.yaml should be updated as well

[kiashok]

@dmcgowan @fuweid @mikebrow updated the PR to v0.29.1

[mikebrow]

LGTM noting we should tag, to this PR, the open issues/pr(s) handling the following cri changes for v028.2 -> v0.29.1:

1. ImageSpec struct now contains RuntimeHandler string ... and a GetRuntimeHandler()
2. ImageFsInfoResponse now contains ContainerFilesystems []*FilesystemUsage ... and a GetContainerFilesystems()