Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7 backport] Add WithReadonlyTempMount to create readonly temporary mounts #8300

Merged
merged 1 commit into from Mar 22, 2023
Merged

[release/1.7 backport] Add WithReadonlyTempMount to create readonly temporary mounts #8300

merged 1 commit into from Mar 22, 2023

Conversation

laurazard
Copy link
Member

Backport of #8259

Backporting since we'd like to use this in:

potential concerns

the changes do functionally change the code in diff/walking/differ.go - Compare() to make the temp mount readonly. I don't think that should introduce any issues (and addresses #6077) but I thought it worth mentioning.

@laurazard @zouyee
Add WithReadonlyTempMount to create readonly temporary mounts
b7d87b1 
This is necessary so we can mount snapshots more than once with overlayfs,
otherwise mounts enter an unknown state.

related: moby/buildkit#1100

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Co-authored-by: Zou Nengren <zouyee1989@gmail.com>
(cherry picked from commit daa3a76)
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@laurazard
Copy link
Member Author

/cc @thaJeztah

@k8s-ci-robot
Copy link

Hi @laurazard. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@laurazard
Copy link
Member Author

/cc @dmcgowan @AkihiroSuda

@AkihiroSuda
Copy link
Member

/ok-to-test

thaJeztah
thaJeztah approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also see the discussion on the 1.6 backport; #8299

@laurazard
Copy link
Member Author

Failures look unrelated, but I can't rerun them afaict

@dmcgowan dmcgowan merged commit 23c8913 into containerd:release/1.7 Mar 22, 2023
47 checks passed
@kiashok kiashok mentioned this pull request May 5, 2023
Closed
@dmcgowan dmcgowan mentioned this pull request May 9, 2023
Merged
@zhenxuanxin zhenxuanxin mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@laurazard @k8s-ci-robot @AkihiroSuda @dmcgowan @thaJeztah