[release/1.7] Fix console TTY leak in runc shim

[austinvazquez]

Backports #11161 to release/1.7 branch

The cherry-pick for 652e4d0 is not clean as some of the test utility functions are slightly different in release/1.7 and I included a skip for runc shimv1 integration testing which does not support sandbox.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[henry118]

The tests are failing for runc v1, which does not seem to support sandbox/grouping since the service only holds a single init container. Probably we can skip this test case for runc v1 configs.

containerd/runtime/v2/runc/v1/service.go

Lines 89 to 103 in bcc810d

	type service struct {
	mu sync.Mutex
	eventSendMu sync.Mutex
	context context.Context
	events chan interface{}
	platform stdio.Platform
	ec chan runcC.Exit
	ep oom.Watcher
	id string
	container *runc.Container
	cancel func()
	}

[austinvazquez]

@henry118, I see good point. Let me try that.

[chrishenzie]

Hello! Just checking if this is still blocked / if there's any updates to share?

[austinvazquez]

Sorry for the delay. Huge find by @henry118 the test was not skipping on runtime "io.containerd.runc.v1". Updated the test now.

[k8s-ci-robot]

@austinvazquez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-containerd-node-e2e-1-7	c3e24e0	link	true	/test pull-containerd-node-e2e-1-7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[henry118]

Lgtm

[estesp]

LGTM

[estesp]

@dims I think this should get into our proposed 1.7 release, but seems we are having e2e test failures here (like on 1.6 as well); happy to help dig into what's going on, but not sure how to gauge whether these are flakes or a real issue we should solve before we do another 1.7.x point release.

[austinvazquez]

@estesp , @dims, FWIW it seems the ResourceMetrics feature test failure seems to be resolved by kubernetes/kubernetes#130053. Also the Node tests failure seems to be a side-effect of the node test suite failing; not a seperate test case IIUC?

[dims]

+1 to skip the flaky test in pull-containerd-node-e2e-1-7. let me do that now.

[dims]

LGTM