[release/1.7] Update AppArmor template to better support rootlesskit #10116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix containerd/nerdctl issue 2730 > [Rootless] `nerdctl rm` fails when AppArmor is loaded: > `error="unknown error after kill: runc did not terminate successfully: exit status 1: > unable to signal init: permission denied\n: unknown"` Caused by: > kernel: audit: type=1400 audit(1713840662.766:122): apparmor="DENIED" operation="signal" class="signal" > profile="nerdctl-default" pid=366783 comm="runc" requested_mask="receive" denied_mask="receive" signal=kill > peer="/usr/local/bin/rootlesskit" The issue is known to happen on Ubuntu 23.10 and 24.04 LTS. Doesn't seem to happen on Ubuntu 22.04 LTS. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit eb5a0c0) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
Is this needed for 1.6 as well, or only 1.7? |
For nerdctl this is only needed for 1.7 regardless to the daemon version, as nerdctl imports containerd 1.7 as the library for generating the |
|
Ah, didn't consider that it was for library code! Yeah, maybe not needed |
dmcgowan
approved these changes
Apr 23, 2024
dmcgowan
changed the title
signal (receive) peer=/usr/local/bin/rootlesskit,signal (receive) peer=/usr/local/bin/rootlesskit, to AppArmor template
dmcgowan
changed the title
signal (receive) peer=/usr/local/bin/rootlesskit, to AppArmor template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick:
signal (receive) peer=/usr/local/bin/rootlesskit,#10111