-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.7] Add support for HPC port forwarding #10008
Conversation
@cpuguy83 @MikeZappa87 @fuweid @kevpar could you please take a look when you have some time please? Its a partial backport of the port forwarding changes that were checked into the containerd/main branch yesterday. Thanks! |
ba893ef
to
4d648f9
Compare
4d648f9
to
4e00d82
Compare
We do not backport a new feature unless there is an exceptional reason |
@AkihiroSuda We get constant requests from customers to fix this. Unfortunately, we missed to check in port forwarding support for HPC therefore we need to fix this in 1.7. What is the process to get this approved? |
@AkihiroSuda is this ok to have? |
cc @margichen |
If this is a bug fix, yes |
@fuweid @MikeZappa87 could you please take a look? Thanks! |
4e00d82
to
e991643
Compare
e991643
to
f649e51
Compare
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
f649e51
to
3df5d44
Compare
@cpuguy83 @MikeZappa87 could you please take a look? :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is a partial change from commit b97ef91fb7212f512487fc1e28106050ad2f5766
This change only adds support for port forwarding on Windows host process containers by establishing connection to localhost at the requested port since HPCs share the network namespace of the host.
This PR does not change any existing behavior for process isolated or hyperV containers since we'd like to limit changes on a release branch.