Skip to content

Commit

Permalink
Merge pull request #9482 from ambarve/sn_cleanup_1.7
Browse files Browse the repository at this point in the history
  • Loading branch information
fuweid committed Dec 8, 2023
2 parents 467de56 + ed7c689 commit de6d8a8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion snapshots/windows/windows.go
Expand Up @@ -280,7 +280,9 @@ func (s *snapshotter) Remove(ctx context.Context, key string) error {
log.G(ctx).WithError(err1).WithField("path", renamed).Error("Failed to rename after failed commit")
}
}
return err
// Return the error wrapped in ErrFailedPrecondition so that cleanup of other snapshots will
// still continue.
return errors.Join(errdefs.ErrFailedPrecondition, err)
}

if err = hcsshim.DestroyLayer(s.info, renamedID); err != nil {
Expand Down

0 comments on commit de6d8a8

Please sign in to comment.