-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize PoolBuilder to not load replaced targets if not required #11449
Optimize PoolBuilder to not load replaced targets if not required #11449
Conversation
@driskell compared to your PR this should get rid of most of the 404 calls but not all of them. Some might still be there because some package actually does // edit: or I missed another place where we should actually call |
Note to self/mergers: This should definitely be |
11cb3dd
to
f994486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this makes sense now!
Thanks everyone for finally getting this through 👍🏻 |
Another attempt to fix #10410 and #9619.
The goal here is to not load replaced packages into the pool if no other package actually requires them. We have to treat all
replace
definitions as "optional packages"./cc @driskell @stof @naderman @Seldaek