Update BinaryInstaller.php #11557
Merged
Update BinaryInstaller.php #11557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/composer/composer/blob/68b7a07187a62435e514324052d5a649b6662efb/src/Composer/Installer/BinaryInstaller.php#L404C4-L404C4 Change `"\${dir}/$binFile" "\$@"` To `sh "\${dir}/$binFile" "\$@"` The file being referenced by `"\${dir}/$binFile" "\$@"` isn't always chmod +x so in situation like running in gitlab-ci workflows, it throwing a Permission Denied error.
|
Thanks |
|
This may also need to be changed for the 2.2 branch. |
|
Yes true, tagged it as such, thanks |
|
I had to revert this due to #11612 - I didn't realize this would take over the default shell but indeed this seems like a bad idea, and as this is just a hack to fix a misconfiguration I think it'd be best that you properly set the execute bit on your executable files instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/composer/composer/blob/68b7a07187a62435e514324052d5a649b6662efb/src/Composer/Installer/BinaryInstaller.php#L404C4-L404C4
Change
"\${dir}/$binFile" "\$@"To
sh "\${dir}/$binFile" "\$@"The file being referenced by
"\${dir}/$binFile" "\$@"isn't always chmod +x so in situation like running in gitlab-ci workflows, it throwing a Permission Denied error.