Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.6.0 broke executable of editorconfigchecker #11612

Closed
janedbal opened this issue Sep 1, 2023 · 5 comments
Closed

Version 2.6.0 broke executable of editorconfigchecker #11612

janedbal opened this issue Sep 1, 2023 · 5 comments
Labels
Milestone

Comments

@janedbal
Copy link

janedbal commented Sep 1, 2023

See CI pipelines executed on the same commit before and after upgrade:

The ec there refers to this library.

@stof
Copy link
Contributor

stof commented Sep 1, 2023

My guess is that this is caused by #11557

By forcing to use sh, it does not rely on the shebang anymore, and so would not use bash anymore (btw, if your script is written in an entirely different language for instance with a shebang saying #!/usr/bin/env python, things would be even worse as some bash scripts could be compatible with the more restricted sh and work by luck)

@stof
Copy link
Contributor

stof commented Sep 1, 2023

/cc @Seldaek

Either the PR should be reverted or it should be reworked to respect the shebang that would get bypassed.

@Seldaek
Copy link
Member

Seldaek commented Sep 1, 2023

Right, reverted in 5fae76c

@Seldaek Seldaek closed this as completed Sep 1, 2023
@Seldaek Seldaek added this to the 2.6 milestone Sep 1, 2023
@Seldaek Seldaek added the Bug label Sep 1, 2023
@Seldaek
Copy link
Member

Seldaek commented Sep 1, 2023

2.6.1 released with the revert

@janedbal
Copy link
Author

janedbal commented Sep 1, 2023

Thank you for such a fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants