Optimize PoolBuilder to not load replaced targets if not required #11449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driskell compared to your PR this should get rid of most of the 404 calls but not all of them. Some might still be there because some package actually does // edit: or I missed another place where we should actually call |
|
Note to self/mergers: This should definitely be |
Toflar
force-pushed
the
fix/poolbuilder-replace-should-be-optional
branch
from
11cb3dd
to
f994486
Compare
naderman
reviewed
May 2, 2023
|
Thanks everyone for finally getting this through 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to fix #10410 and #9619.
The goal here is to not load replaced packages into the pool if no other package actually requires them. We have to treat all
replacedefinitions as "optional packages"./cc @driskell @stof @naderman @Seldaek