Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete functions #743

Merged
merged 1 commit into from
Feb 20, 2025
Merged

remove obsolete functions #743

merged 1 commit into from
Feb 20, 2025

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Feb 20, 2025

see #742

Verified

This commit was signed with the committer’s verified signature.
ndeloof Nicolas De loof
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to do a major version as some downstream projects may still use the Load function, no? WDYT @ndeloof ?

@ndeloof
Copy link
Collaborator Author

ndeloof commented Feb 20, 2025

Load has been deprecated since 1.18 (ad9be94), so they have been warned!

@alexellis
Copy link

Thanks for looking at this.

Isn't there a way to mark a method as deprecated in Go through godoc or similar?

https://github.com/compose-spec/compose-go/pull/743/files#diff-8e9af1e483632eac17610237caaa5f879ea7bfb3e1e1ea228e45a17c770b9432L260

Sometimes a struct field, function, type, or even a whole package becomes redundant or unnecessary, but must be kept for compatibility with existing programs. To signal that an identifier should not be used, add a paragraph to its doc comment that begins with “Deprecated:” followed by some information about the deprecation.

I didn't see that on the ParseYAML function.

@ndeloof
Copy link
Collaborator Author

ndeloof commented Feb 20, 2025

This one was not marker as deprecated as it's just a legacy (not used by the canonical loading sequence as implemented in docker/compose) we forgot to tag as deprecated/remove

@ndeloof ndeloof merged commit 23f270a into compose-spec:main Feb 20, 2025
8 checks passed
@ndeloof ndeloof deleted the cleanup branch February 20, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants