Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage secrets|configs.mode as an octal string||number #738

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Feb 13, 2025

A dedicated decoder is required for services.secrets.mode as octal value can be either yaml octal or a plain string

Closes moby/moby#49404

@ndeloof ndeloof force-pushed the FileMode branch 2 times, most recently from 8fc8d6f to 67bdec0 Compare February 13, 2025 17:29
@ndeloof ndeloof requested review from glours and thaJeztah February 13, 2025 17:29
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not deeply familiar with the codebase, but looks solid, thanks!

LGTM

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours enabled auto-merge (rebase) March 13, 2025 14:50
@glours glours merged commit 6ec1edc into compose-spec:main Mar 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compose secrets does not set the correct mode
3 participants