-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rhino 1.7.15 #1891
Add Rhino 1.7.15 #1891
Conversation
gausie
commented
May 8, 2024
- Add new version environment
- Update instructions at the top of rhino.js
- Update newly passing tests for Rhino 1.7.15
- Fix some old tests that were erroneously marked as true, thus the new falses are not regressions
…the new falses are not regressions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you please rebase and regenerate HTML files?
@chicoxyzzy ill take care of it :-) reminder that PRs still need two green checks before they can be landed. |
(also, the consecutive falses are necessary and desired; every version that a human has verified should have an entry in the data) |
Noted, thanks. Everywhere an old one was turned to false needs an extra
false added now then. I am ill at the moment so can get to it over the
weekend.
…On Wed, 29 May 2024 at 18:51, Jordan Harband ***@***.***> wrote:
(also, the consecutive falses are necessary and desired; every version
that a human has verified should have an entry in the data)
—
Reply to this email directly, view it on GitHub
<#1891 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABL4LUF5C7NJM3O2OPW4E3ZEYIQ7AVCNFSM6AAAAABHNGSHRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXHE2TQOJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sounds good, we'll fix that in a followup. |