Disk cache load fails after 304 Not Modified when cached headers include non-ASCII characters #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2023 12:39
…haracters coil-kt#1838 Allows disk cache headers to be updated after a 304 Not Modified, as detailed in coil-kt#1838
colinrtwhite
approved these changes
Aug 10, 2023
colinrtwhite
added a commit
that referenced
this pull request
Aug 10, 2023
* main: Bump androidx.benchmark:benchmark-macro-junit4 (#1841) Bump androidx.compose.ui:ui-test-junit4 from 1.4.3 to 1.5.0 (#1842) Bump compose from 1.4.3 to 1.5.0 (#1840) Disk cache load fails after 304 Not Modified when cached headers include non-ASCII characters (#1839) Remove the Okio Proguard rule. (#1837) Bump okio from 3.4.0 to 3.5.0 (#1836) Bump androidx.recyclerview:recyclerview from 1.3.0 to 1.3.1 (#1832) Bump androidx.benchmark:benchmark-macro-junit4 (#1831) Fix coil-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1838