[coil-video] Support MediaDataSource implementations #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspieper
changed the title
coil-video/src/androidTest/java/coil/decode/MediaDataSourceOkIoSourceTest.kt
Outdated
Show resolved
Hide resolved
coil-video/src/androidTest/java/coil/decode/MediaDataSourceOkIoSourceTest.kt
Outdated
Show resolved
Hide resolved
|
You'll also need to run |
|
I think I adjusted every recommendation from your feedback. Sorry for the delay, was very busy the last days. So there are just two questions left. Looking forward to your next input. |
colinrtwhite
reviewed
Jul 3, 2023
colinrtwhite
reviewed
Jul 3, 2023
|
Added a few minor comments, but otherwise LGTM. I'm probably going to hold off merging this until #1764 is resolved so we can ship a |
|
Alright, let me know if there is anything else I can do. |
|
Actually it looks more likely that the next version will be |
colinrtwhite
approved these changes
Jul 25, 2023
colinrtwhite
added a commit
that referenced
this pull request
Jul 26, 2023
* main: Guard against Painters that return a Size with one unbounded dimension. (#1826) Fix test.sh. Update Kotlin to 1.9.0 and androidx.core to 1.10.1. (#1827) Bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 (#1825) Bump coroutines from 1.7.2 to 1.7.3 (#1824) [coil-video] Support MediaDataSource implementations (#1795)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1790
So this is my take on your recommended implementation. There are
TODOs were I'm looking for some feedback from you.Thanks again.