chore: add verifier assets for codexdisttestnetwork #89
+143
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
changed the title
markspanbroek
approved these changes
Feb 26, 2024
|
Thanks for looking into this Adam! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporary fixes the non-functional distributed tests, which were failing on the non-existingPUSH0opcode. This opcode was introduced in the Shangai upgrade.I originally tried to upgrade the Geth setup in dist. tests to support the Shangai upgrade, but with having--minerfunctionality Geth refused to enable it. It turned out that as it is Post-Merge upgrade it would require more complicated setup (ethereum/go-ethereum#28449 https://dev.to/q9/how-to-merge-an-ethereum-network-right-from-the-genesis-block-3454).So instead I decided to lower the Solidity's compile EVM target to pre-Shangai upgrade as a temporary measure as first version of the testnet will run against our PoA network. When we will deploy to some existing testnet with Shangai support we should revisit this, although then we will also need a solution for dist tests. Maybe the Geth's--devmode could be then the answer? Not sure.EDIT: Ben was able to create Geth node image with Shangai upgrade, so the reverting part of the compiled target is not necessary. Only thing left for having the contracts successfully deployed on Dist. test is the missing verifier assets for that network. I have added them and they are for now identical to
hardhatnetwork.