Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy python 2 object subclassing #2464

Closed
wants to merge 0 commits into from
Closed

Remove legacy python 2 object subclassing #2464

wants to merge 0 commits into from

Conversation

kkirsche
Copy link

This removes unnecessary subclassing of object as this library supports Python 3.6+

This stuff is a holdover from:
https://docs.python.org/2/reference/datamodel.html#new-style-and-classic-classes

Python 3 doesn't have any of this, so there is no benefit to doing this

peternewman
peternewman approved these changes Sep 11, 2022
View reviewed changes
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fairly sensible from the docs, but hasn't had much impact on me personally...

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 26, 2022

@peternewman bump

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Sep 27, 2022 •
edited

While the request does not fix any bug, it is not without impact: sticking to Python 3 documentation will ease future maintenance.

Duplicate of #2085 and #2364.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdufresne jdufresne jdufresne approved these changes

@peternewman peternewman peternewman approved these changes

Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kkirsche @luzpaz @DimitriPapadopoulos @jdufresne @peternewman