Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install optional dependencies (required for swc) #335

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Feb 20, 2022

  • Use install script in Makefile

Please also review the changes in this commit, which I accidentally pushed to master: 8f843d2

@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #335 (9be2ffc) into main (8f843d2) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   67.80%   67.62%   -0.19%     
==========================================
  Files          73      142      +69     
  Lines        6914     7700     +786     
  Branches        0       77      +77     
==========================================
+ Hits         4688     5207     +519     
- Misses       1710     1964     +254     
- Partials      516      529      +13     
Flag Coverage Δ
unittest-go-macos-latest 66.44% <ø> (+0.28%) ⬆️
unittest-go-ubuntu-latest 67.68% <ø> (+0.26%) ⬆️
unittest-go-windows-2022 65.79% <ø> (+0.01%) ⬆️
unittest-js 63.61% <ø> (?)
Impacted Files Coverage Δ
provisionerd/provisionerd.go 69.72% <0.00%> (-0.20%) ⬇️
site/components/User/UserAvatar.tsx 87.50% <0.00%> (ø)
site/components/Navbar/UserDropdown.tsx 88.00% <0.00%> (ø)
site/pages/cli-auth.tsx 0.00% <0.00%> (ø)
site/forms/CreateProjectForm.tsx 95.45% <0.00%> (ø)
site/components/ErrorSummary/index.tsx 60.00% <0.00%> (ø)
site/components/Form/PasswordField.tsx 86.66% <0.00%> (ø)
site/components/Table/Table.tsx 100.00% <0.00%> (ø)
site/components/Icons/index.ts 100.00% <0.00%> (ø)
site/pages/workspaces/[user]/[workspace].tsx 0.00% <0.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f843d2...9be2ffc. Read the comment docs.

@jawnsy jawnsy requested review from kylecarbs and bryphe-coder and removed request for kylecarbs February 20, 2022 18:01
@jawnsy jawnsy self-assigned this Feb 20, 2022
@jawnsy jawnsy marked this pull request as ready for review February 20, 2022 18:01
@kylecarbs
Copy link
Member

The test flake seen is being tracked here: #317

We know the root cause, and are fixing it!

@kylecarbs kylecarbs merged commit 3c04c7f into main Feb 20, 2022
@kylecarbs kylecarbs deleted the jawnsy/chore-remove-no-optional branch February 20, 2022 19:52
@jawnsy jawnsy removed their assignment Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants