fix: Leaking yamux session after HTTP handler is closed #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #317. We depended on the context canceling the yamux connection, but this isn't a sync operation. Explicitly calling close ensures the handler waits for yamux to complete before exit.
coderd/provisionerdaemons.go
Outdated
Comment on lines
87
to
89
| defer func() { | ||
| _ = session.Close() | ||
| }() |
There was a problem hiding this comment.
Awesome! Nice find @kylecarbs 🎉 This looks like it should fix some of those goleaks that are picked up after the test runs.
bryphe-coder
approved these changes
Feb 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 63.61% 63.61%
=======================================
Files 69 69
Lines 786 786
Branches 77 77
=======================================
Hits 500 500
Misses 271 271
Partials 15 15
Continue to review full report at Codecov.
|
|
Still happened after this change. I believe I understand why though, and am working on a fix: https://github.com/coder/coder/runs/5251190813?check_suite_focus=true#step:7:45 |
kylecarbs
force-pushed
the
closeconn
branch
4 times, most recently
from
ca2202d
to
eaf3a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #317. We depended on the context canceling the yamux connection,
but this isn't a sync operation. Explicitly calling close ensures the
handler waits for yamux to complete before exit.