Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix site descriptor (revert partially PR #161) #182

Merged
merged 1 commit into from
May 28, 2023
Merged

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented May 24, 2023

when upgrading to this parent POM, child projects must do 2 things:

  1. explicitely declare a url in their pom.xml (they currently usually don't have it, but just inherited default value that is now wrong)
  2. override the whole breadcrumbs in their site.xml

= for example https://github.com/codehaus-plexus/plexus-xml/pull/18/files

understanding the why:

  1. before PR Refresh Maven site #161, url was expected to be automagically inherited to child from parent value and child artifactId; This was done at the cost of parent POM inconsistency between its url and the content of site.xml, that lead to complex understanding of urls relativisation. Let's keep it simple and just declare <url> in each child project
  2. in child projects, by default, breadcrumbs from parent will be used and additionam breadcrumb will be used: this leads to a breadcrumb to parent POM project = not something we expect. Redeclaring full breadcrumbs from the start will override content from parent

a little bit of copy paste will make things much simpler than the initial intended magic that was causing headache

@hboutemy hboutemy merged commit f482aa6 into master May 28, 2023
28 checks passed
@hboutemy hboutemy deleted the fix-site-config branch May 28, 2023 08:24
@@ -39,6 +39,8 @@

<body>
<breadcrumbs>
<item name="Plexus" href="https://codehaus-plexus.github.io/"/>
<item name="Parent POM" href="https://codehaus-plexus.github.io/plexus-pom"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a link to parent in breadcrumbs?
We have a link to parent in menu items ...
@hboutemy @michael-o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants