Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle license check - depend on file from released branch #167

Merged
merged 1 commit into from
May 3, 2023

Conversation

slachiewicz
Copy link
Member

File in master can change or can be deleted

Closes #166

File in master can change or can be deleted

Closes #166
@slachiewicz slachiewicz added the bug label May 3, 2023
@slachiewicz slachiewicz merged commit d66da28 into master May 3, 2023
6 checks passed
@slachiewicz slachiewicz deleted the checkstyle-license branch May 3, 2023 22:27
@olamy
Copy link
Member

olamy commented May 4, 2023

If I understand correctly every project upgrading to this parent will fail if any single source file doesn't have this header?
Then how to fix the build?

@hboutemy
Copy link
Member

hboutemy commented May 5, 2023

oh, you're right <headerLocation>https://raw.github.com/codehaus-plexus/plexus-pom/master/src/main/resources/config/plexus-header.txt</headerLocation> is not really a safe value

notice that IIUC, we're switching to spotless for checks about this, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkstyle license check depends on file in Github master branch
4 participants