Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Maven 3.2.5+ #160

Merged
merged 1 commit into from Apr 29, 2023
Merged

Require Maven 3.2.5+ #160

merged 1 commit into from Apr 29, 2023

Conversation

slachiewicz
Copy link
Member

No description provided.

@slachiewicz slachiewicz merged commit 508784f into master Apr 29, 2023
6 checks passed
@slachiewicz slachiewicz deleted the maven-3.2.5 branch April 29, 2023 17:14
@olamy
Copy link
Member

olamy commented Apr 30, 2023

not sure to understand why do we have 3.2.5+ here but 3.5.4+ for compiler codehaus-plexus/plexus-compiler#283 (review) ?
any reason for this and not having parent 3.5.4+ so components will be upgraded when upgrading parent component?

@slachiewicz
Copy link
Member Author

Becouse when I started with upgrade, many issues where rised. See logs from GHA

@olamy
Copy link
Member

olamy commented Apr 30, 2023

I would say let's upgrade parent directly to 3.5.4+ same as for compiler.
or we will need to upgrade again in few months and maybe do the job twice.
which logs from GHA? I can't see anything in this PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants