Add java bytecode class file version detection #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorsol
force-pushed
the
147-detection-java-class-file
branch
from
b32a170
to
6c93a04
Compare
rfscholte
requested changes
Aug 30, 2023
plexus-java/src/main/java/org/codehaus/plexus/languages/java/version/JavaClassVersion.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jorge Solórzano <jorsol@ongres.com>
jorsol
force-pushed
the
147-detection-java-class-file
branch
from
6c93a04
to
b092334
Compare
slachiewicz
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation for the detection of the Java Class File version and mapping with the JavaVersion.
This should work for all Java versions and in the future it could allow an implementation for the classfile API by providing JavaClassfileVersionParser in the versioning area.
Feedback is welcome!
Closes #147