Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AspectJ Compiler to 1.9.21 to support Java 21 #330

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Update AspectJ Compiler to 1.9.21 to support Java 21 #330

merged 2 commits into from
Dec 11, 2023

Conversation

slachiewicz
Copy link
Member

@slachiewicz slachiewicz added enhancement dependencies Pull requests that update a dependency file labels Dec 11, 2023
@slawekjaranowski
Copy link
Member

Do you try build with Maven 3.9.5?

@slawekjaranowski
Copy link
Member

IT aspectj-compiler will fail with Maven 3.9.5 we should invoke it with Maven 3.9.6+

slawekjaranowski
slawekjaranowski requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit IT aspectj-compiler with Maven 3.9.6+

@slachiewicz
Copy link
Member Author

Good point, thx.

@slachiewicz slachiewicz merged commit 4bc179f into master Dec 11, 2023
35 checks passed
@slachiewicz slachiewicz deleted the aspectj branch December 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slachiewicz @slawekjaranowski