Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discovering javaSource based on maven.compiler properties, default as 8 #405

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

slawekjaranowski
Copy link
Member

We can recognize based on properties:

  • maven.compiler.release
  • maven.compiler.source
  • maven.compiler.target

fix #194

…fault as 8

We can recognize based on properties:
- maven.compiler.release
- maven.compiler.source
- maven.compiler.target

fix #194
@slawekjaranowski slawekjaranowski merged commit c07c8fd into master Jan 9, 2024
26 checks passed
@slawekjaranowski slawekjaranowski deleted the fix-194 branch January 9, 2024 15:55
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modello:java mojo javaSource parameter default assumes compiler source is used
3 participants