Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to Cloudfile and populate the S3 version with tags. #542

Merged
merged 3 commits into from Apr 12, 2024

Conversation

bseeger
Copy link
Contributor

@bseeger bseeger commented Apr 10, 2024

Issue tracking number πŸ”—

Part of the solution for MD Pilot issue: https://www.pivotaltracker.com/story/show/187339289

Description of change ✍️

This creates a new metadata field in the Cloudfile class.
It also adds metadata about tags to the S3 implementation of the S3CloudFileRepository.java

Priority πŸ₯‡

I would need this pretty quickly - w/in a few days maybe? :D

Effect on other applications using FFB 🌊

This should not break anything and should be invisible to any app that doesn't want extra metadata passed back about a file.

Testing

βœ… Checklist before requesting a review

  • Does the new code follow our preferred coding
    style
    ?
  • Does the code include javadocs, where necessary?
  • Have tests for this feature been added / updated?
  • Has the readme been updated?

@bseeger
Copy link
Contributor Author

bseeger commented Apr 10, 2024

I need to update the readme.

@bseeger bseeger marked this pull request as ready for review April 11, 2024 15:04
@coltborg
Copy link
Contributor

@bseeger, I'm not able to see the MD pivotal tracker board.

@coltborg
Copy link
Contributor

I need to update the readme.

Do you still need to update the Readme?

@bseeger
Copy link
Contributor Author

bseeger commented Apr 11, 2024

Screenshot 2024-04-11 at 11 55 58β€―AM

Hi @coltborg this is a screen shot of the ticket. Basically we need to check the tags associated with the file in S3. This adds that ability to share any metadata the implementation (in this case S3) deems worth to share via the "metadata" field.

@coltborg
Copy link
Contributor

Screenshot 2024-04-11 at 11 55 58β€―AM

Hi @coltborg this is a screen shot of the ticket. Basically we need to check the tags associated with the file in S3. This adds that ability to share any metadata the implementation (in this case S3) deems worth to share via the "metadata" field.

Thank you for the context!

Copy link
Contributor

@coltborg coltborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@bseeger bseeger merged commit 5861883 into main Apr 12, 2024
5 checks passed
@bseeger bseeger deleted the add_metadata_to_cloudfile branch April 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants