Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Th/remove gpg #88

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Th/remove gpg #88

merged 4 commits into from
Sep 13, 2024

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Sep 13, 2024

fixes #76

this is effectively a copy+paste of codecov/codecov-action#1426

Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just a question about the reordering of function calls

};

await importKey();
await verifySignature();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to be reordering the calls to validateSha and verifySignature wrt the calls to gpg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-sentry the calls aren't reordered, it would break if we did that (I believe)

verifySignature runs validateSha in a callback in the original code. In this, we are just calling them sequentially

@thomasrockhu-codecov thomasrockhu-codecov merged commit 7c17a47 into main Sep 13, 2024
10 of 12 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/remove-gpg branch September 13, 2024 19:08
@nohant
Copy link

nohant commented Sep 19, 2024

when a release is scheduled to move this one into main usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: write EPIPE
3 participants