Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isPullRequestFromFork returns false for any PR #1437

Merged
merged 7 commits into from
May 20, 2024

Conversation

shahar-h
Copy link
Contributor

@shahar-h shahar-h commented May 18, 2024

Fixes #1435

Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @shahar-h, thank you

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (d42a336) to head (4597db2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
- Coverage   91.29%   90.35%   -0.94%     
==========================================
  Files           4        4              
  Lines         310      311       +1     
  Branches       85       85              
==========================================
- Hits          283      281       -2     
  Misses         27       27              
- Partials        0        3       +3     
Flag Coverage Δ
demo 90.35% <100.00%> (-0.94%) ⬇️
macos-latest 90.35% <100.00%> (-0.94%) ⬇️
script 90.35% <100.00%> (-0.94%) ⬇️
ubuntu-latest 90.35% <100.00%> (-0.94%) ⬇️
version 90.35% <100.00%> (-0.94%) ⬇️
windows-latest 90.35% <100.00%> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrockhu-codecov thomasrockhu-codecov merged commit c9dbf6a into codecov:main May 20, 2024
9 of 10 checks passed
@shahar-h shahar-h deleted the patch-1 branch May 20, 2024 13:22
peterjokumsen added a commit to helderberg-pirates-baseball/websites that referenced this pull request May 26, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [codecov/codecov-action](https://togithub.com/codecov/codecov-action)
| action | patch | `v4.4.0` -> `v4.4.1` |

---

### Release Notes

<details>
<summary>codecov/codecov-action (codecov/codecov-action)</summary>

###
[`v4.4.1`](https://togithub.com/codecov/codecov-action/releases/tag/v4.4.1)

[Compare
Source](https://togithub.com/codecov/codecov-action/compare/v4.4.0...v4.4.1)

#### What's Changed

- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 7.8.0 to 7.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[codecov/codecov-action#1427
- fix: prevent xlarge from running on forks by
[@&#8203;thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov)
in
[codecov/codecov-action#1432
- build(deps): bump github/codeql-action from 3.25.4 to 3.25.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[codecov/codecov-action#1439
- build(deps): bump actions/checkout from 4.1.5 to 4.1.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[codecov/codecov-action#1438
- fix: isPullRequestFromFork returns false for any PR by
[@&#8203;shahar-h](https://togithub.com/shahar-h) in
[codecov/codecov-action#1437
- chore(release): 4.4.1 by
[@&#8203;thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov)
in
[codecov/codecov-action#1441

#### New Contributors

- [@&#8203;shahar-h](https://togithub.com/shahar-h) made their first
contribution in
[codecov/codecov-action#1437

**Full Changelog**:
codecov/codecov-action@v4.4.0...v4.4.1

#### What's Changed

- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 7.8.0 to 7.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[codecov/codecov-action#1427
- fix: prevent xlarge from running on forks by
[@&#8203;thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov)
in
[codecov/codecov-action#1432
- build(deps): bump github/codeql-action from 3.25.4 to 3.25.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[codecov/codecov-action#1439
- build(deps): bump actions/checkout from 4.1.5 to 4.1.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[codecov/codecov-action#1438
- fix: isPullRequestFromFork returns false for any PR by
[@&#8203;shahar-h](https://togithub.com/shahar-h) in
[codecov/codecov-action#1437
- chore(release): 4.4.1 by
[@&#8203;thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov)
in
[codecov/codecov-action#1441

#### New Contributors

- [@&#8203;shahar-h](https://togithub.com/shahar-h) made their first
contribution in
[codecov/codecov-action#1437

**Full Changelog**:
codecov/codecov-action@v4.4.0...v4.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuNiIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: Renovate Bot GitHub <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov tries to fetch oidc token also on PR from fork
2 participants