Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: bincheck: bind 127.0.0.1 #113525

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 31, 2023

Backport 1/1 commits from #113502 on behalf of @rail.

/cc @cockroachdb/release


Previously, bincheck started a single node database instance without specifying the address/port it listens on. In this case the server code tried to resolve the hostname and use it. See

// No specific listen address, use the canonical host name.
for the details.

At some point this method stopped working on MacOS GitHub workers. There is an upstream issue open: actions/runner-images#8649

This PR explicitly sets the --listen-addr parameter to skip the problematic code.

Epic: none
Release note: None


Release justification: release automation changes

Previously, bincheck started a single node database instance without
specifying the address/port it listens on. In this case the server code
tried to resolve the hostname and use it. See
https://github.com/cockroachdb/cockroach/blob/d498a59cc2afc9778af6f7e0120206ab1ee56bc2/pkg/base/addr_validation.go#L128
for the details.

At some point this method stopped working on MacOS GitHub workers. There
is an upstream issue open: actions/runner-images#8649

This PR explicitly sets the `--listen-addr` parameter to skip the
problematic code.

Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 31, 2023 19:00
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-113502 branch from 7b3828c to cbbb5c2 Compare October 31, 2023 19:00
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 31, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-113502 branch from 5eac81e to cbdb1de Compare October 31, 2023 19:00
Copy link
Author

blathers-crl bot commented Oct 31, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 31, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail merged commit f2b4a81 into release-23.1 Oct 31, 2023
6 checks passed
@rail rail deleted the blathers/backport-release-23.1-113502 branch October 31, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants