Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tool): Kitex Tool exits abnormally when -use is used #1713

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix(tool): 当使用 -use 时 Kitex Tool 异常退出

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
When -use is specified and the thriftgo SDK is used, the error message is inerrrather thanout, they both need to be parsed.

zh(optional):
当指定 -use 并且使用 thriftgo SDK 时,错误信息存在于err而不是out中,需要对这两种情况都进行解析。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Sorry, something went wrong.

@DMwangnima DMwangnima requested review from a team as code owners February 24, 2025 03:41
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.44%. Comparing base (8bde660) to head (9979047).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
tool/cmd/kitex/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1713      +/-   ##
===========================================
+ Coverage    57.36%   57.44%   +0.08%     
===========================================
  Files          408      408              
  Lines        37693    37696       +3     
===========================================
+ Hits         21621    21653      +32     
+ Misses       14749    14726      -23     
+ Partials      1323     1317       -6     
Flag Coverage Δ
integration 45.92% <ø> (+0.03%) ⬆️
unit 51.87% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DMwangnima DMwangnima force-pushed the fix/tool_exit_abnormally branch from caa5101 to ec042d7 Compare February 25, 2025 09:54
@DMwangnima DMwangnima force-pushed the fix/tool_exit_abnormally branch from ec042d7 to 9979047 Compare February 26, 2025 01:53
@DMwangnima DMwangnima merged commit dc17ebf into cloudwego:develop Feb 26, 2025
21 of 22 checks passed
@DMwangnima DMwangnima deleted the fix/tool_exit_abnormally branch February 26, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants