Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mw): MiddlewareBuilder can return nil #1640

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

AsterDY
Copy link
Contributor

@AsterDY AsterDY commented Dec 12, 2024

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: MiddlewareBuilder can return nil, because some scenario need to decide if produce middleware based on environment
zh(optional): MiddlewareBuilder 可以返回空,因为有些场景需要根据环境决定是否构建中间件

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Sorry, something went wrong.

@AsterDY AsterDY requested review from a team as code owners December 12, 2024 06:43
@AsterDY AsterDY changed the base branch from develop to main December 12, 2024 06:45
@AsterDY AsterDY marked this pull request as draft December 12, 2024 06:45
@AsterDY AsterDY force-pushed the feat/err_section_block branch from 689dbea to 5040b28 Compare December 13, 2024 03:40
@AsterDY AsterDY changed the title feat(kerror): add SectionBlockErr basic err feat(mw): MiddlewareBuilder can return nil Dec 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@AsterDY AsterDY marked this pull request as ready for review January 6, 2025 08:15
jayantxie
jayantxie previously approved these changes Jan 6, 2025
@AsterDY AsterDY merged commit b639017 into main Jan 7, 2025
71 checks passed
@AsterDY AsterDY deleted the feat/err_section_block branch January 7, 2025 08:22
@AsterDY AsterDY restored the feat/err_section_block branch January 7, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants