Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): Add reusable workflow files #9518

Closed
wants to merge 7 commits into from

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Mar 31, 2023

Add reusable workflows that will allow us to reuse the common job definitions:

Once this part is in the main we can switch parts of the workflows to the reusable ones.

Example implementation: #9541 (aws source).

@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Mar 31, 2023
@candiduslynx candiduslynx added no automerge and removed automerge Automatically merge once required checks pass labels Mar 31, 2023
@candiduslynx candiduslynx added automerge Automatically merge once required checks pass and removed no automerge labels Mar 31, 2023
@candiduslynx candiduslynx self-assigned this Mar 31, 2023
@candiduslynx
Copy link
Contributor Author

@erezrokah I think we might want to reconsider what runners we want to be used & when.
I propose using the large runners on main branch only or not use them at all.

The reason for them is simple: we would move from caching during release to caching from main branch. This enables:

  1. Direct hits from other branches, as caches are inherited from the default branch (main)
  2. Always storing the cache only from main

@erezrokah
Copy link
Contributor

erezrokah commented Apr 4, 2023

@erezrokah I think we might want to reconsider what runners we want to be used & when. I propose using the large runners on main branch only or not use them at all.

The reason for them is simple: we would move from caching during release to caching from main branch. This enables:

  1. Direct hits from other branches, as caches are inherited from the default branch (main)
  2. Always storing the cache only from main

Can you open an issue describing the reasoning? I don't think a PR is the right place to discuss why we should do something nor do I see a downside with using large runners for PRs for big plugins.
Additionally we should discuss any caching changes in an issue as I'm not sure we'd like to mix between caches without properly discussing the impact

@candiduslynx candiduslynx added no automerge and removed automerge Automatically merge once required checks pass labels Apr 5, 2023
kodiakhq bot pushed a commit that referenced this pull request Apr 9, 2023
Extracted from #9518.

Implemented using relative call + added dependency on the reusable workflow file changes.

Part of reusable workflows (#9655) implementation
@candiduslynx
Copy link
Contributor Author

Drop for now, take another shot after #9780

@candiduslynx candiduslynx deleted the feat/workflows/reusable branch April 10, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants