Support parsing of environment variables other than strings. #425
+186
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the go-cfclient throws an error when attempting to retrieve env vars for an app that are not of type string.
For example, given the env vars:
We observe the following failure:
time=2024-07-15T20:43:48.368890666Z caller=logger.go:73 level=error error="failed to get environment for app a275abd1-8f53-4a63-b980-d81cee1cf133: error decoding /v3/apps/a275abd1-8f53-4a63-b980-d81cee1cf133/env get response JSON before '': json: cannot unmarshal bool into Go struct field AppEnvironment.environment_variables of type string"
We added support for bool, float64 and int types. More could easily be added given our implementation but we weren't sure what other types could actually occur. Let us know if you have any questions or would like additional changes.