Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update vue version(2.7.14 -> 2.7.15) #2596

Merged

Conversation

sulmoJ
Copy link
Member

@sulmoJ sulmoJ commented Dec 23, 2023

To Reviewers

  • Skip (style, chore, ci, minor refactoring, etc.)
  • Need discussion
  • Not that difficult
  • Approved feature branch merge to master

Description

vuejs/vue#13070
Users who are in the process of migrating to Vue 3 and are utilizing Pinia are in need of a crucial update. This update aims to restore the proper functionality of Pinia getters that were not working correctly.

⚠️ Please check within your scope of work for any functional errors. ⚠️

Things to Talk About

Signed-off-by: sulmo <sulmo@megazone.com>
Copy link

vercel bot commented Dec 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 6:06am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
dev-playground ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2023 6:06am
storybook ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2023 6:06am

Copy link
Member

@yuda110 yuda110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Signed-off-by: sulmo <sulmo@megazone.com>
Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS

@sulmoJ sulmoJ merged commit 207200a into cloudforet-io:feature-workspace-fundametals Dec 23, 2023
5 checks passed
@sulmoJ sulmoJ deleted the vue-version branch December 23, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants