Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Graduate experimental RPC support for Workers with assets in local dev #8597

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Mar 20, 2025

Fixes DEVX-1670


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: we are not calling this out in particular in our docs
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: new feature

Sorry, something went wrong.

@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners March 20, 2025 16:37
Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 00bb25a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@cloudflare/vitest-pool-workers Minor
miniflare Minor
wrangler Minor
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CarmenPopoviciu CarmenPopoviciu added the e2e Run wrangler e2e tests on a PR label Mar 20, 2025
@CarmenPopoviciu CarmenPopoviciu changed the title feat: Graduate experimental RPC support for Workers with assets in local dev [DO NOT MERGE YET] feat: Graduate experimental RPC support for Workers with assets in local dev Mar 20, 2025
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/remove-rpc-experimental-flag branch from 87cb762 to 5922799 Compare March 20, 2025 16:55
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/remove-rpc-experimental-flag branch from 5922799 to da9b4a8 Compare March 21, 2025 06:33
Copy link
Contributor

github-actions bot commented Mar 21, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-wrangler-8597

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8597/npm-package-wrangler-8597

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-wrangler-8597 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-workers-bindings-extension-8597 -O ./cloudflare-workers-bindings-extension.0.0.0-v33cf9ff97.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v33cf9ff97.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-create-cloudflare-8597 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-kv-asset-handler-8597

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-miniflare-8597

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-pages-shared-8597

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-unenv-preset-8597

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-vite-plugin-8597

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-vitest-pool-workers-8597

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-workers-editor-shared-8597

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-workers-shared-8597

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13991624718/npm-package-cloudflare-workflows-shared-8597

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.3.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250319.0
workerd 1.20250319.0 1.20250319.0
workerd --version 1.20250319.0 2025-03-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/remove-rpc-experimental-flag branch from da9b4a8 to 181a306 Compare March 21, 2025 07:07
@CarmenPopoviciu CarmenPopoviciu changed the title [DO NOT MERGE YET] feat: Graduate experimental RPC support for Workers with assets in local dev feat: Graduate experimental RPC support for Workers with assets in local dev Mar 21, 2025
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/remove-rpc-experimental-flag branch 2 times, most recently from c08e722 to 3a1d390 Compare March 21, 2025 10:58
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/remove-rpc-experimental-flag branch from 3a1d390 to 00bb25a Compare March 21, 2025 12:22
@CarmenPopoviciu CarmenPopoviciu merged commit 5d78760 into main Mar 21, 2025
25 of 27 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/remove-rpc-experimental-flag branch March 21, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants