Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error messaging when the user provides neither an entry point nor an asset directory #8534

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Mar 17, 2025

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor message change
  • Wrangler V3 Backport

Sorry, something went wrong.

@petebacondarwin petebacondarwin added the e2e Run wrangler e2e tests on a PR label Mar 17, 2025
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 17, 2025 20:32
Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: d6bc4ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 17, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-wrangler-8534

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8534/npm-package-wrangler-8534

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-wrangler-8534 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workers-bindings-extension-8534 -O ./cloudflare-workers-bindings-extension.0.0.0-v815872514.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v815872514.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-create-cloudflare-8534 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-kv-asset-handler-8534

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-miniflare-8534

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-pages-shared-8534

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-unenv-preset-8534

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-vite-plugin-8534

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-vitest-pool-workers-8534

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workers-editor-shared-8534

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workers-shared-8534

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workflows-shared-8534

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.2.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250317.1
workerd 1.20250317.0 1.20250317.0
workerd --version 1.20250317.0 2025-03-17

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin force-pushed the pbd/wrangler/update-missing-main-message branch from 523d952 to ebdf09d Compare March 19, 2025 14:53
@petebacondarwin petebacondarwin force-pushed the pbd/wrangler/update-missing-main-message branch from 6c47204 to d6bc4ed Compare March 19, 2025 17:09
@petebacondarwin petebacondarwin merged commit 62d5471 into main Mar 19, 2025
46 of 61 checks passed
@petebacondarwin petebacondarwin deleted the pbd/wrangler/update-missing-main-message branch March 19, 2025 21:53
petebacondarwin added a commit that referenced this pull request Mar 20, 2025
* Improve the error messaging when the user provides neither an entry point nor an asset directory

* copy edits

---------

Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants