Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metafiles in child directory #8503

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Mar 14, 2025

Fixes WC-3357.

Metafiles weren't being picked up when Wrangler was running in a different directory. This fixes that. Thanks for catching that, @petebacondarwin !


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

Sorry, something went wrong.

@GregBrimble GregBrimble requested a review from a team as a code owner March 14, 2025 16:18
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 79dcece

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GregBrimble GregBrimble added skip-pr-description-validation Skip validation of the required PR description format and removed skip-pr-description-validation Skip validation of the required PR description format labels Mar 14, 2025
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-wrangler-8503

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8503/npm-package-wrangler-8503

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-wrangler-8503 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-workers-bindings-extension-8503 -O ./cloudflare-workers-bindings-extension.0.0.0-v3e678900c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3e678900c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-create-cloudflare-8503 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-kv-asset-handler-8503

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-miniflare-8503

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-pages-shared-8503

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-unenv-preset-8503

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-vite-plugin-8503

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-vitest-pool-workers-8503

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-workers-editor-shared-8503

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-workers-shared-8503

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13860867265/npm-package-cloudflare-workflows-shared-8503

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.0.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250310.0
workerd 1.20250310.0 1.20250310.0
workerd --version 1.20250310.0 2025-03-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen merged commit edf169d into main Mar 17, 2025
38 of 42 checks passed
@emily-shen emily-shen deleted the fix-metafiles-in-child-directory branch March 17, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants