Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler deploy: Add containers configuration to PUT script #8477

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

gabivlj
Copy link
Contributor

@gabivlj gabivlj commented Mar 13, 2025

Right now, container configuration only works on the PUT script path, but this will be fixed in further API changes.

This change makes sure that when container configurations are included in wrangler, it will include the containers configuration in wrangler deploy. These changes break wrangler cloudchamber apply users, but as the product is in early-stages and private only for now, we consider these breaking changes worth doing.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: No e2e tests for containers yet.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal features

Sorry, something went wrong.

Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: 42087ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gabivlj gabivlj force-pushed the gv/containers-5 branch 4 times, most recently from 5f2f25e to 9f41c82 Compare March 13, 2025 16:41
@gabivlj gabivlj marked this pull request as ready for review March 13, 2025 16:44
@gabivlj gabivlj requested review from a team as code owners March 13, 2025 16:44
@gabivlj gabivlj force-pushed the gv/containers-5 branch 2 times, most recently from 1b67cbc to 580bbfc Compare March 13, 2025 17:07
Copy link
Contributor

github-actions bot commented Mar 13, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-wrangler-8477

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8477/npm-package-wrangler-8477

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-wrangler-8477 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-workers-bindings-extension-8477 -O ./cloudflare-workers-bindings-extension.0.0.0-v9fe1f3b29.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v9fe1f3b29.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-create-cloudflare-8477 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-kv-asset-handler-8477

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-miniflare-8477

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-pages-shared-8477

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-unenv-preset-8477

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-vite-plugin-8477

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-vitest-pool-workers-8477

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-workers-editor-shared-8477

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-workers-shared-8477

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13908924454/npm-package-cloudflare-workflows-shared-8477

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.0.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250310.0
workerd 1.20250310.0 1.20250310.0
workerd --version 1.20250310.0 2025-03-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Right now, container configuration only works on the PUT script path,
but this will be fixed in further API changes.
@gabivlj
Copy link
Contributor Author

gabivlj commented Mar 17, 2025

thx for the review @emily-shen !

@gabivlj gabivlj merged commit fd9dff8 into main Mar 18, 2025
33 of 35 checks passed
@gabivlj gabivlj deleted the gv/containers-5 branch March 18, 2025 00:14
@lrapoport-cf lrapoport-cf mentioned this pull request Mar 18, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants