Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include asset binding when printing binding summary #8435

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Mar 10, 2025

Fixes #8313
Screenshot 2025-03-10 at 17 26 17


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport

Sorry, something went wrong.

@emily-shen emily-shen requested a review from a team as a code owner March 10, 2025 18:06
Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 97bba60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen changed the title Emily/print assets binding fix: include asset binding when printing binding summary Mar 10, 2025
@workers-devprod workers-devprod added the e2e Run wrangler e2e tests on a PR label Mar 10, 2025
Copy link
Contributor

github-actions bot commented Mar 10, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-wrangler-8435

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8435/npm-package-wrangler-8435

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-wrangler-8435 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-workers-bindings-extension-8435 -O ./cloudflare-workers-bindings-extension.0.0.0-vb9b0e25ff.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb9b0e25ff.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-create-cloudflare-8435 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-kv-asset-handler-8435

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-miniflare-8435

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-pages-shared-8435

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-unenv-preset-8435

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-vite-plugin-8435

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-vitest-pool-workers-8435

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-workers-editor-shared-8435

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-workers-shared-8435

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14082130489/npm-package-cloudflare-workflows-shared-8435

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.4.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.0
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen force-pushed the emily/print-assets-binding branch from 2ae330b to ec4b9a3 Compare March 13, 2025 14:50
@emily-shen emily-shen force-pushed the emily/print-assets-binding branch from ec4b9a3 to d6fa1d4 Compare March 25, 2025 13:38
@emily-shen emily-shen added the skip-pr-description-validation Skip validation of the required PR description format label Mar 25, 2025
@CarmenPopoviciu CarmenPopoviciu force-pushed the emily/print-assets-binding branch from cb365ad to 97bba60 Compare March 26, 2025 11:26
@CarmenPopoviciu CarmenPopoviciu merged commit 8e3688f into main Mar 26, 2025
26 of 38 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the emily/print-assets-binding branch March 26, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: erroneously reports "no bindings found" when using Workers Assets
3 participants