Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mysql options to hyperdrive #8258

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

knickish
Copy link
Contributor

@knickish knickish commented Feb 25, 2025

Part of RM-17419

Adds mysql-related options to the wrangler hyperdrive CLI


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: No database ready to test creation flow
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Feature not publicly available yet
  • Wrangler V3 Backport
    • TODO (before merge)
    • PR:
    • Not necessary because: this is a new feature

Sorry, something went wrong.

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: cd93a87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Patch
wrangler Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@knickish knickish marked this pull request as ready for review February 25, 2025 16:04
@knickish knickish requested a review from a team as a code owner February 25, 2025 16:04
Copy link
Contributor

@Ltadrian Ltadrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - hyperdrive

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the backend already support mysql? In other words if we land and release this change will things break if a user tries to connect to mysql?

While I have approve this (with some suggestions) we should not merge it until the API is ready.

@petebacondarwin petebacondarwin added blocked Blocked on other work internal Requires support from the Cloudflare Platform labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-wrangler-8258

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8258/npm-package-wrangler-8258

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-wrangler-8258 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workers-bindings-extension-8258 -O ./cloudflare-workers-bindings-extension.0.0.0-v00d9d8c8e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v00d9d8c8e.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-create-cloudflare-8258 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-kv-asset-handler-8258

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-miniflare-8258

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-pages-shared-8258

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-unenv-preset-8258

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-vite-plugin-8258

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-vitest-pool-workers-8258

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workers-editor-shared-8258

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workers-shared-8258

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workflows-shared-8258

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.1.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250317.0
workerd 1.20250317.0 1.20250317.0
workerd --version 1.20250317.0 2025-03-17

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@ReppCodes
Copy link

Does the backend already support mysql? In other words if we land and release this change will things break if a user tries to connect to mysql?

While I have approve this (with some suggestions) we should not merge it until the API is ready.

The control plane will intentionally return an error, it's currently gated to "@cloudflare.com" users while we're developing. It won't just choke, though.

@knickish knickish force-pushed the hyperdrive_mysql branch 2 times, most recently from 08ff3e6 to b5d037d Compare March 6, 2025 16:27
@knickish knickish force-pushed the hyperdrive_mysql branch 3 times, most recently from 15a8765 to ab98d58 Compare March 11, 2025 14:14
@knickish knickish force-pushed the hyperdrive_mysql branch 2 times, most recently from 8b5478f to 4d0f66c Compare March 18, 2025 13:55
@emily-shen emily-shen added the skip-v3-pr Skip validation of presence of a v3 backport PR label Mar 18, 2025
@penalosa penalosa merged commit 9adbd50 into cloudflare:main Mar 19, 2025
17 of 18 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Mar 19, 2025
Copy link

holopin-bot bot commented Mar 19, 2025

Congratulations @knickish, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm8fu4lp658510cl4fcs75g7t

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@lrapoport-cf lrapoport-cf mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other work contribution [Holopin] Recognizes an open-source contribution, big or small internal Requires support from the Cloudflare Platform skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

8 participants