-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mysql options to hyperdrive #8258
Conversation
🦋 Changeset detectedLatest commit: cd93a87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6b113ec
to
44665aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - hyperdrive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the backend already support mysql? In other words if we land and release this change will things break if a user tries to connect to mysql?
While I have approve this (with some suggestions) we should not merge it until the API is ready.
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-wrangler-8258 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8258/npm-package-wrangler-8258 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-wrangler-8258 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workers-bindings-extension-8258 -O ./cloudflare-workers-bindings-extension.0.0.0-v00d9d8c8e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v00d9d8c8e.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-create-cloudflare-8258 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-kv-asset-handler-8258 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-miniflare-8258 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-pages-shared-8258 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-unenv-preset-8258 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-vite-plugin-8258 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-vitest-pool-workers-8258 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workers-editor-shared-8258 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workers-shared-8258 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13929001529/npm-package-cloudflare-workflows-shared-8258 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
The control plane will intentionally return an error, it's currently gated to "@cloudflare.com" users while we're developing. It won't just choke, though. |
08ff3e6
to
b5d037d
Compare
15a8765
to
ab98d58
Compare
8b5478f
to
4d0f66c
Compare
4d0f66c
to
cd93a87
Compare
Congratulations @knickish, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm8fu4lp658510cl4fcs75g7t This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Part of RM-17419
Adds mysql-related options to the wrangler hyperdrive CLI