Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit Content-Type header for files of unknown extension in Workers Assets #8248

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Feb 25, 2025

Fixes WC-3028.

The third part of #8247. Before merging, we need backend API support for "application/null".


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation

Sorry, something went wrong.

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: 8da34c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GregBrimble GregBrimble added the blocked Blocked on other work label Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-wrangler-8248

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8248/npm-package-wrangler-8248

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-wrangler-8248 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-workers-bindings-extension-8248 -O ./cloudflare-workers-bindings-extension.0.0.0-vb8acc28b4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb8acc28b4.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-create-cloudflare-8248 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-kv-asset-handler-8248

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-miniflare-8248

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-pages-shared-8248

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-unenv-preset-8248

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-vite-plugin-8248

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-vitest-pool-workers-8248

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-workers-editor-shared-8248

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-workers-shared-8248

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13523171665/npm-package-cloudflare-workflows-shared-8248

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.109.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Base automatically changed from prepare-for-support-of-null-content-types to main February 25, 2025 13:58
@GregBrimble GregBrimble marked this pull request as ready for review February 25, 2025 15:03
@GregBrimble GregBrimble requested a review from a team as a code owner February 25, 2025 15:03
@GregBrimble GregBrimble removed the blocked Blocked on other work label Feb 25, 2025
@GregBrimble GregBrimble merged commit 1cb2d34 into main Feb 26, 2025
22 of 24 checks passed
@GregBrimble GregBrimble deleted the support-null-content-types branch February 26, 2025 15:04
@lrapoport-cf
Copy link
Contributor

for posterity: @GregBrimble confirmed that the API part had been released and tested it manually before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants