Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render correct config format from wrangler d1 create #8119

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

penalosa
Copy link
Contributor

Output correct config format from wrangler d1 create. Previously, this command would always output TOML, regardless of the config file format


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by unit tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

Sorry, something went wrong.

@penalosa penalosa requested review from a team as code owners February 12, 2025 19:51
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 1ccccbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 12, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-wrangler-8119

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8119/npm-package-wrangler-8119

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-wrangler-8119 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-workers-bindings-extension-8119 -O ./cloudflare-workers-bindings-extension.0.0.0-v50721c8fd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v50721c8fd.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-create-cloudflare-8119 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-kv-asset-handler-8119

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-miniflare-8119

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-pages-shared-8119

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-unenv-preset-8119

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-vite-plugin-8119

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-vitest-pool-workers-8119

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-workers-editor-shared-8119

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-workers-shared-8119

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13294177653/npm-package-cloudflare-workflows-shared-8119

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.108.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 1bc60d7 into main Feb 13, 2025
27 checks passed
@penalosa penalosa deleted the penalosa/d1-output-fix branch February 13, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants