Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metrics event for provisioning #8077

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Feb 10, 2025

Fixes [DEVX-1618]
Sends a new adhoc telemetry event since the dispatcher cannot (currently) be used in command handlers.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: single metrics event - these haven't been tested anywhere else and don't affect functionality
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: single metrics event - these haven't been tested anywhere else and don't affect functionality
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: unreleased feature

Sorry, something went wrong.

@emily-shen emily-shen requested a review from a team as a code owner February 10, 2025 11:26
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 4c75874

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 10, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-wrangler-8077

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8077/npm-package-wrangler-8077

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-wrangler-8077 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-workers-bindings-extension-8077 -O ./cloudflare-workers-bindings-extension.0.0.0-ve1aebfa28.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ve1aebfa28.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-create-cloudflare-8077 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-kv-asset-handler-8077

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-miniflare-8077

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-pages-shared-8077

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-unenv-preset-8077

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-vite-plugin-8077

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-vitest-pool-workers-8077

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-workers-editor-shared-8077

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-workers-shared-8077

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13240066084/npm-package-cloudflare-workflows-shared-8077

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.107.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want a changeset for this change?

@emily-shen emily-shen merged commit 60310cd into main Feb 10, 2025
28 checks passed
@emily-shen emily-shen deleted the emily/provisioning-metrics branch February 10, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants