Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local tags for durable objects and vectorize #7750

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

andyjessop
Copy link
Contributor

@andyjessop andyjessop commented Jan 13, 2025

Part of DEVX-1574

As part of the drive to improve the messaging surrounding local and remote resources in wrangler dev, this PR fixes two issues that were found:

  1. Vectorize is remote-only - there is no emulator in Miniflare - yet it is marked as local in the development console.
  2. Durable Objects are indeed run locally, but the local tag is not applied.

So, this PR removes the local tag from Vectorize bindings, and adds it to Durable Object bindings.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fixes.

Sorry, something went wrong.

@andyjessop andyjessop added the e2e Run wrangler e2e tests on a PR label Jan 13, 2025
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 3172729

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 13, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-wrangler-7750

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7750/npm-package-wrangler-7750

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-wrangler-7750 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-workers-bindings-extension-7750 -O ./cloudflare-workers-bindings-extension.0.0.0-v41bc0139f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v41bc0139f.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-create-cloudflare-7750 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-kv-asset-handler-7750

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-miniflare-7750

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-pages-shared-7750

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-unenv-preset-7750

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-vitest-pool-workers-7750

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-workers-editor-shared-7750

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-workers-shared-7750

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12750034602/npm-package-cloudflare-workflows-shared-7750

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.101.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop marked this pull request as ready for review January 13, 2025 14:54
@andyjessop andyjessop requested a review from a team as a code owner January 13, 2025 14:54
@andyjessop andyjessop merged commit df0e5be into main Jan 14, 2025
31 checks passed
@andyjessop andyjessop deleted the aj/remove-local-tag-from-vectorize branch January 14, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants