Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor performance improvement to the url polyfill used by the vitest integration #6700

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

petebacondarwin
Copy link
Contributor

What this PR solves / how to test

This aligns our code with the best practice added to the node.js runtime recently.
See nodejs/node@7196946

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: refactoring already covered by current tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: vitest integration node covered by e2e
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal refactoring

Sorry, something went wrong.

…test integration
@petebacondarwin petebacondarwin requested a review from a team as a code owner September 13, 2024 07:52
Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 1254d6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-wrangler-6700

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6700/npm-package-wrangler-6700

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-wrangler-6700 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-create-cloudflare-6700 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-cloudflare-kv-asset-handler-6700
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-miniflare-6700
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-cloudflare-pages-shared-6700
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-cloudflare-vitest-pool-workers-6700
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-cloudflare-workers-editor-shared-6700
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10845244709/npm-package-cloudflare-workers-shared-6700

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.77.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.0
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit d6c1dd2 into main Sep 13, 2024
21 checks passed
@petebacondarwin petebacondarwin deleted the update-url-polyfill branch September 13, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants