Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure console methods are bound to instance #6633

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

andyjessop
Copy link
Contributor

What this PR solves / how to test

Fixes #5591.

This solution proxies all methods to a bound version of the same method. Another way to solve this could have been to manually write out each binding.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: bug fix

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@andyjessop andyjessop requested a review from a team as a code owner September 4, 2024 12:41
Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 867e4d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andyjessop andyjessop added the e2e Run wrangler e2e tests on a PR label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-wrangler-6633

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6633/npm-package-wrangler-6633

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-wrangler-6633 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-create-cloudflare-6633 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-kv-asset-handler-6633
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-miniflare-6633
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-pages-shared-6633
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-vitest-pool-workers-6633
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-workers-editor-shared-6633
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-workers-shared-6633

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.74.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop merged commit 1a4b4ba into main Sep 4, 2024
28 checks passed
@andyjessop andyjessop deleted the aj/fix-detatched-console-methods branch September 4, 2024 13:09
@workers-devprod workers-devprod mentioned this pull request Sep 4, 2024
penalosa pushed a commit that referenced this pull request Sep 9, 2024
* fix: ensure console methods are bound to instance

* chore: add changeset

* chore: better description

---------

Co-authored-by: Andy Jessop <ajessop@cloudflare.com>
@Codex-
Copy link
Contributor

Codex- commented Sep 10, 2024

This pr was perfectly timed as it fixes an issue I was about to report where if you mock the implementation of the console (vi.spyOn(console, 'log').mockImplementation(() => undefined)) to make it silent (useful when wanting to assert output without lots of test noise) it would offset the mocks by n + 1 lol

So, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Weird crash when logging from the console object
3 participants