-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure console methods are bound to instance #6633
Conversation
🦋 Changeset detectedLatest commit: 867e4d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-wrangler-6633 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6633/npm-package-wrangler-6633 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-wrangler-6633 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-create-cloudflare-6633 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-kv-asset-handler-6633 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-miniflare-6633 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-pages-shared-6633 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-vitest-pool-workers-6633 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-workers-editor-shared-6633 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10701888670/npm-package-cloudflare-workers-shared-6633 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
* fix: ensure console methods are bound to instance * chore: add changeset * chore: better description --------- Co-authored-by: Andy Jessop <ajessop@cloudflare.com>
This pr was perfectly timed as it fixes an issue I was about to report where if you mock the implementation of the console ( So, thank you! |
What this PR solves / how to test
Fixes #5591.
This solution proxies all methods to a bound version of the same method. Another way to solve this could have been to manually write out each binding.
Author has addressed the following