Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D1] add queryEfficiency to d1 insights output #6463

Conversation

AnantharamanSI
Copy link
Contributor

What this PR solves / how to test

This PR adds query efficiency to the d1 insights output.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: only command output has changed
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: insights is an experimental command with no documentation.

Sorry, something went wrong.

@AnantharamanSI AnantharamanSI requested review from a team as code owners August 9, 2024 22:46
Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 54eb351

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-wrangler-6463

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6463/npm-package-wrangler-6463

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-wrangler-6463 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-create-cloudflare-6463 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-cloudflare-kv-asset-handler-6463
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-miniflare-6463
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-cloudflare-pages-shared-6463
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-cloudflare-vitest-pool-workers-6463
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-cloudflare-workers-editor-shared-6463
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10326651415/npm-package-cloudflare-workers-shared-6463

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.70.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit dbc6782 into cloudflare:main Aug 13, 2024
18 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Aug 13, 2024
Copy link

holopin-bot bot commented Aug 13, 2024

Congratulations @AnantharamanSI, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/clzs84wze57770cl6angq8muk

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@AnantharamanSI AnantharamanSI deleted the display-query-efficiency-d1-insights branch August 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants