-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --x-dev-env for Pages #6097
Conversation
🦋 Changeset detectedLatest commit: b5ff4c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
31fa3a2
to
40fa56c
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-wrangler-6097 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6097/npm-package-wrangler-6097 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-wrangler-6097 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-create-cloudflare-6097 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-cloudflare-kv-asset-handler-6097 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-miniflare-6097 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-cloudflare-pages-shared-6097 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-cloudflare-vitest-pool-workers-6097 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits.
packages/wrangler/src/api/startDevWorker/LocalRuntimeController.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good. There are some flakes, perhaps?
What this PR solves / how to test
Fixes DEVX-1296
Author has addressed the following