fix(wrangler) wrangler kv:key put does not work as expected #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c57876 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
approved these changes
Apr 17, 2024
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8728909223/npm-package-wrangler-5619You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5619/npm-package-wrangler-5619Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8728909223/npm-package-wrangler-5619 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8728909223/npm-package-create-cloudflare-5619 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8728909223/npm-package-cloudflare-kv-asset-handler-5619npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8728909223/npm-package-miniflare-5619npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8728909223/npm-package-cloudflare-pages-shared-5619npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8728909223/npm-package-cloudflare-vitest-pool-workers-5619Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
gmemstr
force-pushed
the
patch-1
branch
2 times, most recently
from
307178a
to
7d96f7c
Compare
gmemstr
commented
Apr 17, 2024
gmemstr
force-pushed
the
patch-1
branch
7 times, most recently
from
58eca2e
to
5282b66
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Currently, when passing a path to
kv:key put --path, the contents of the file are read in as a Buffer, which would normally be fine - however, when we also have--metadatadefined, the payload is transformed intoFormData.FormDatacan take astring,BloborFile, and will fall back tostringfor everything else. Because we loaded the file as a Buffer, the file contents are then transformed into a string by the library being used (undici). Normally this is okay unless you are not uploading a text-based document, e.g an image file.Fixes #2911.
Author has addressed the following
Minor change correcting behaviour to what is expected